[ADD] estate: doing the tutorial#1281
Conversation
|
|
aboo-odoo
left a comment
aboo-odoo
left a comment
There was a problem hiding this comment.
Good work but still for more to do 🥳 I'm being extra-picky so that I can transmit as much information as possible. If there is anything you disagree with, please share it without fear.
Some comments apply at several places but I've only written it once to save some time and to not cumbersome the PR, when you check and update according to one of my comment, check that this comment does not apply elsewhere before moving to the next one 😄
A generic comment:
- your PR/commit body could be a little more exhaustive a good template is to follow is
STEPS to reproduce the bug (only for bugfixes)
PROBLEM - what is the problem
GOAL - what do we want to achieve
SOLUTION - how did we achieve it
task-XXXXXX
- can you squash all your commits: come to me and I'll show you how 😄
| @@ -0,0 +1,51 @@ | |||
| from odoo import models, fields, api, exceptions | |||
| import datetime as dt | |||
There was a problem hiding this comment.
It is preferable to only import the method you need when you can. Here you only use timedelta
| import datetime as dt | |
| from datetime import timedelta |
| @@ -0,0 +1,51 @@ | |||
| from odoo import models, fields, api, exceptions | |||
There was a problem hiding this comment.
| from odoo import models, fields, api, exceptions | |
| from odoo import models, fields, api | |
| from odoo.exceptions import UserError, ValidationError |
| from odoo import models, fields, api, exceptions | ||
| import datetime as dt | ||
|
|
||
| class test(models.Model): |
There was a problem hiding this comment.
| class test(models.Model): | |
| class EstatePropertyOffer(models.Model): |
| import datetime as dt | ||
|
|
||
| class test(models.Model): | ||
| _name = "est_property_offers" |
There was a problem hiding this comment.
Singular over plural When defining an Odoo Model : use singular form of the name
| _name = "est_property_offers" | |
| _name = "est_property_offer" |
| @@ -0,0 +1,51 @@ | |||
| from odoo import models, fields, api, exceptions | |||
There was a problem hiding this comment.
Imports should follow RUFF specification, i.e; the ASCII order and be grouped into 3 categories:
- General python library
- Imports of odoo
- Imports from Odoo modules
Problem: Odoo has no real way to handle real estate businesses. Solution: Created a module to handle the real estate business. task-6231250
ROM4N0
force-pushed
the
19.0-Tutorial-nutav
branch
from
6a3811f to
80f6692
Compare
3 participants
No description provided.